Arduino led + visual studio

[mateusz_brudnik]

czy można włączyć więcej, ponieważ mój kod nie działa najlepiej z powodu powtarzających się cyfr

void setup() {

Serial.begin(9600);
pinMode(2, OUTPUT);
pinMode(3, OUTPUT);
pinMode(4, OUTPUT);
pinMode(5, OUTPUT);
pinMode(6, OUTPUT);
pinMode(7, OUTPUT);
pinMode(8, OUTPUT);
pinMode(9, OUTPUT);
pinMode(10, OUTPUT);
pinMode(11, OUTPUT);
pinMode(12, OUTPUT);
pinMode(13, OUTPUT);
pinMode(14, OUTPUT);
pinMode(15, OUTPUT);
pinMode(16, OUTPUT);
pinMode(17, OUTPUT);
pinMode(18, OUTPUT);
pinMode(19, OUTPUT);
pinMode(20, OUTPUT);
pinMode(21, OUTPUT);
pinMode(22, OUTPUT);
pinMode(23, OUTPUT);
pinMode(24, OUTPUT);
pinMode(25, OUTPUT);
pinMode(26, OUTPUT);
pinMode(27, OUTPUT);
pinMode(28, OUTPUT);
pinMode(29, OUTPUT);
pinMode(30, OUTPUT);
pinMode(31, OUTPUT);
pinMode(32, OUTPUT);
pinMode(33, OUTPUT);
pinMode(34, OUTPUT);
pinMode(35, OUTPUT);
pinMode(36, OUTPUT);
pinMode(37, OUTPUT);
pinMode(38, OUTPUT);
pinMode(39, OUTPUT);
pinMode(40, OUTPUT);
pinMode(41, OUTPUT);
pinMode(42, OUTPUT);
pinMode(43, OUTPUT);
pinMode(44, OUTPUT);
pinMode(45, OUTPUT);
pinMode(46, OUTPUT);
pinMode(47, OUTPUT);
pinMode(48, OUTPUT);
pinMode(49, OUTPUT);
pinMode(50, OUTPUT);
pinMode(51, OUTPUT);
pinMode(52, OUTPUT);
pinMode(53, OUTPUT);
digitalWrite(2, LOW);
digitalWrite(3, LOW);
digitalWrite(4, LOW);
digitalWrite(5, LOW);
digitalWrite(6, LOW);
digitalWrite(7, LOW);
digitalWrite(8, LOW);
digitalWrite(9, LOW);
digitalWrite(10, LOW);
digitalWrite(11, LOW);
digitalWrite(12, LOW);
digitalWrite(13, LOW);
digitalWrite(14, LOW);
digitalWrite(15, LOW);
digitalWrite(16, LOW);
digitalWrite(17, LOW);
digitalWrite(18, LOW);
digitalWrite(19, LOW);
digitalWrite(20, LOW);
digitalWrite(21, LOW);
digitalWrite(22, LOW);
digitalWrite(23, LOW);
digitalWrite(24, LOW);
digitalWrite(25, LOW);
digitalWrite(26, LOW);
digitalWrite(27, LOW);
digitalWrite(28, LOW);
digitalWrite(29, LOW);
digitalWrite(30, LOW);
digitalWrite(31, LOW);
digitalWrite(32, LOW);
digitalWrite(33, LOW);
digitalWrite(34, LOW);
digitalWrite(35, LOW);
digitalWrite(36, LOW);
digitalWrite(37, LOW);
digitalWrite(38, LOW);
digitalWrite(39, LOW);
digitalWrite(40, LOW);
digitalWrite(41, LOW);
digitalWrite(42, LOW);
digitalWrite(43, LOW);
digitalWrite(44, LOW);
digitalWrite(45, LOW);
digitalWrite(46, LOW);
digitalWrite(47, LOW);
digitalWrite(48, LOW);
digitalWrite(49, LOW);
digitalWrite(50, LOW);
digitalWrite(51, LOW);
digitalWrite(52, LOW);
digitalWrite(53, LOW);
}


void loop(){
while (Serial.available() == 0); 
int val = Serial.read() - '0';

if (val == 1) { 
Serial.println("LED on");
digitalWrite(2, HIGH); 
}
else if (val == 0) 
{
Serial.println("LED OFF");
digitalWrite(2, LOW); 
}
else 
{

}
if (val == 2) { 
Serial.println("LED on");
digitalWrite(3, HIGH); 
}
else if (val == 3) 
{
Serial.println("LED OFF");
digitalWrite(3, LOW); 
}
else 
{

}
if (val == 4) { 
Serial.println("LED on");
digitalWrite(4, HIGH); 
}
else if (val == 5) 
{
Serial.println("LED OFF");
digitalWrite(4, LOW); 
}
else 
{

}

if (val == 6) { 
Serial.println("LED on");
digitalWrite(5, HIGH); 
}
else if (val == 7) 
{
Serial.println("LED OFF");
digitalWrite(5, LOW); 
}
else 
{

}

if (val == 8) { 
Serial.println("LED on");
digitalWrite(6, HIGH); 
}
else if (val == 9) 
{
Serial.println("LED OFF");
digitalWrite(6, LOW); 
}
else 
{

}

if (val == 10) { 
Serial.println("LED on");
digitalWrite(7, HIGH); 
}
else if (val == 11) 
{
Serial.println("LED OFF");
digitalWrite(7, LOW); 
}
else 
{

}

if (val == 12) { 
Serial.println("LED on");
digitalWrite(8, HIGH); 
}
else if (val == 13) 
{
Serial.println("LED OFF");
digitalWrite(8, LOW); 
}
else 
{

}

if (val == 14) { 
Serial.println("LED on");
digitalWrite(9, HIGH); 
}
else if (val == 15) 
{
Serial.println("LED OFF");
digitalWrite(9, LOW); 
}
else 
{

}

if (val == 16) { 
Serial.println("LED on");
digitalWrite(10, HIGH); 
}
else if (val == 17) 
{
Serial.println("LED OFF");
digitalWrite(10, LOW); 
}
else 
{

}

if (val == 18) { 
Serial.println("LED on");
digitalWrite(11, HIGH); 
}
else if (val == 19) 
{
Serial.println("LED OFF");
digitalWrite(11, LOW); 
}
else 
{

}

if (val == 20) { 
Serial.println("LED on");
digitalWrite(12, HIGH); 
}
else if (val == 21) 
{
Serial.println("LED OFF");
digitalWrite(12, LOW); 
}
else 
{

}

if (val == 22) { 
Serial.println("LED on");
digitalWrite(13, HIGH); 
}
else if (val == 23) 
{
Serial.println("LED OFF");
digitalWrite(13, LOW); 
}
else 
{

}

if (val == 24) { 
Serial.println("LED on");
digitalWrite(14, HIGH); 
}
else if (val == 25) 
{
Serial.println("LED OFF");
digitalWrite(14, LOW); 
}
else 
{

}

if (val == 26) { 
Serial.println("LED on");
digitalWrite(15, HIGH); 
}
else if (val == 27) 
{
Serial.println("LED OFF");
digitalWrite(15, LOW); 
}
else 
{

}

if (val == 28) { 
Serial.println("LED on");
digitalWrite(16, HIGH); 
}
else if (val == 29) 
{
Serial.println("LED OFF");
digitalWrite(16, LOW); 
}
else 
{

}

if (val == 30) { 
Serial.println("LED on");
digitalWrite(17, HIGH); 
}
else if (val == 31) 
{
Serial.println("LED OFF");
digitalWrite(17, LOW); 
}
else 
{

}

if (val == 32) { 
Serial.println("LED on");
digitalWrite(18, HIGH); 
}
else if (val == 33) 
{
Serial.println("LED OFF");
digitalWrite(18, LOW); 
}
else 
{

}

if (val == 34) { 
Serial.println("LED on");
digitalWrite(19, HIGH); 
}
else if (val == 35) 
{
Serial.println("LED OFF");
digitalWrite(19, LOW); 
}
else 
{

}

if (val == 36) { 
Serial.println("LED on");
digitalWrite(20, HIGH); 
}
else if (val == 37) 
{
Serial.println("LED OFF");
digitalWrite(20, LOW); 
}
else 
{

}

if (val == 38) { 
Serial.println("LED on");
digitalWrite(21, HIGH); 
}
else if (val == 39) 
{
Serial.println("LED OFF");
digitalWrite(21, LOW); 
}
else 
{

}

if (val == 40) { 
Serial.println("LED on");
digitalWrite(22, HIGH); 
}
else if (val == 41) 
{
Serial.println("LED OFF");
digitalWrite(22, LOW); 
}
else 
{

}

if (val == 42) { 
Serial.println("LED on");
digitalWrite(23, HIGH); 
}
else if (val == 43) 
{
Serial.println("LED OFF");
digitalWrite(23, LOW); 
}
else 
{

}

if (val == 44) { 
Serial.println("LED on");
digitalWrite(24, HIGH); 
}
else if (val == 45) 
{
Serial.println("LED OFF");
digitalWrite(24, LOW); 
}
else 
{

}

if (val == 46) { 
Serial.println("LED on");
digitalWrite(25, HIGH); 
}
else if (val == 47) 
{
Serial.println("LED OFF");
digitalWrite(25, LOW); 
}
else 
{

}

if (val == 48) { 
Serial.println("LED on");
digitalWrite(26, HIGH); 
}
else if (val == 49) 
{
Serial.println("LED OFF");
digitalWrite(26, LOW); 
}
else 
{

}

if (val == 50) { 
Serial.println("LED on");
digitalWrite(27, HIGH); 
}
else if (val == 51) 
{
Serial.println("LED OFF");
digitalWrite(27, LOW); 
}
else 
{

}

if (val == 52) { 
Serial.println("LED on");
digitalWrite(28, HIGH); 
}
else if (val == 53) 
{
Serial.println("LED OFF");
digitalWrite(28, LOW); 
}
else 
{

}

if (val == 54) { 
Serial.println("LED on");
digitalWrite(29, HIGH); 
}
else if (val == 55) 
{
Serial.println("LED OFF");
digitalWrite(29, LOW); 
}
else 
{

}

if (val == 56) { 
Serial.println("LED on");
digitalWrite(30, HIGH); 
}
else if (val == 57) 
{
Serial.println("LED OFF");
digitalWrite(30, LOW); 
}
else 
{

}

if (val == 58) { 
Serial.println("LED on");
digitalWrite(31, HIGH); 
}
else if (val == 59) 
{
Serial.println("LED OFF");
digitalWrite(31, LOW); 
}
else 
{

}

if (val == 60) { 
Serial.println("LED on");
digitalWrite(32, HIGH); 
}
else if (val == 61) 
{
Serial.println("LED OFF");
digitalWrite(32, LOW); 
}
else 
{

}

if (val == 62) { 
Serial.println("LED on");
digitalWrite(33, HIGH); 
}
else if (val == 63) 
{
Serial.println("LED OFF");
digitalWrite(33, LOW); 
}
else 
{

}

if (val == 64) { 
Serial.println("LED on");
digitalWrite(34, HIGH); 
}
else if (val == 65) 
{
Serial.println("LED OFF");
digitalWrite(34, LOW); 
}
else 
{

}

if (val == 66) { 
Serial.println("LED on");
digitalWrite(35, HIGH); 
}
else if (val == 67) 
{
Serial.println("LED OFF");
digitalWrite(35, LOW); 
}
else 
{

}

if (val == 68) { 
Serial.println("LED on");
digitalWrite(36, HIGH); 
}
else if (val == 69) 
{
Serial.println("LED OFF");
digitalWrite(36, LOW); 
}
else 
{

}

if (val == 70) { 
Serial.println("LED on");
digitalWrite(37, HIGH); 
}
else if (val == 71) 
{
Serial.println("LED OFF");
digitalWrite(37, LOW); 
}
else 
{

}

if (val == 72) { 
Serial.println("LED on");
digitalWrite(38, HIGH); 
}
else if (val == 73) 
{
Serial.println("LED OFF");
digitalWrite(38, LOW); 
}
else 
{

}

if (val == 74) { 
Serial.println("LED on");
digitalWrite(39, HIGH); 
}
else if (val == 75) 
{
Serial.println("LED OFF");
digitalWrite(39, LOW); 
}
else 
{

}

if (val == 76) { 
Serial.println("LED on");
digitalWrite(40, HIGH); 
}
else if (val == 77) 
{
Serial.println("LED OFF");
digitalWrite(40, LOW); 
}
else 
{

}

if (val == 78) { 
Serial.println("LED on");
digitalWrite(41, HIGH); 
}
else if (val == 79) 
{
Serial.println("LED OFF");
digitalWrite(41, LOW); 
}
else 
{

}

if (val == 80) { 
Serial.println("LED on");
digitalWrite(42, HIGH); 
}
else if (val == 81) 
{
Serial.println("LED OFF");
digitalWrite(42, LOW); 
}
else 
{

}

if (val == 82) { 
Serial.println("LED on");
digitalWrite(43, HIGH); 
}
else if (val == 83) 
{
Serial.println("LED OFF");
digitalWrite(43, LOW); 
}
else 
{

}

if (val == 84) { 
Serial.println("LED on");
digitalWrite(44, HIGH); 
}
else if (val == 85) 
{
Serial.println("LED OFF");
digitalWrite(44, LOW); 
}
else 
{

}

if (val == 86) { 
Serial.println("LED on");
digitalWrite(45, HIGH); 
}
else if (val == 87) 
{
Serial.println("LED OFF");
digitalWrite(45, LOW); 
}
else 
{

}

if (val == 88) { 
Serial.println("LED on");
digitalWrite(46, HIGH); 
}
else if (val == 89) 
{
Serial.println("LED OFF");
digitalWrite(46, LOW); 
}
else 
{

}

if (val == 90) { 
Serial.println("LED on");
digitalWrite(47, HIGH); 
}
else if (val == 91) 
{
Serial.println("LED OFF");
digitalWrite(47, LOW); 
}
else 
{

}

if (val == 92) { 
Serial.println("LED on");
digitalWrite(48, HIGH); 
}
else if (val == 93) 
{
Serial.println("LED OFF");
digitalWrite(48, LOW); 
}
else 
{

}

if (val == 94) { 
Serial.println("LED on");
digitalWrite(49, HIGH); 
}
else if (val == 95) 
{
Serial.println("LED OFF");
digitalWrite(49, LOW); 
}
else 
{

}

if (val == 96) { 
Serial.println("LED on");
digitalWrite(50, HIGH); 
}
else if (val == 97) 
{
Serial.println("LED OFF");
digitalWrite(50, LOW); 
}
else 
{

}

if (val == 98) { 
Serial.println("LED on");
digitalWrite(51, HIGH); 
}
else if (val == 99) 
{
Serial.println("LED OFF");
digitalWrite(51, LOW); 
}
else 
{

}

if (val == 100) { 
Serial.println("LED on");
digitalWrite(52, HIGH); 
}
else if (val == 101) 
{
Serial.println("LED OFF");
digitalWrite(52, LOW); 
}
else 
{

}

if (val == 102) { 
Serial.println("LED on");
digitalWrite(53, HIGH); 
}
else if (val == 103) 
{
Serial.println("LED OFF");
digitalWrite(53, LOW); 
}
else 
{

}

Serial.println(val);
Serial.flush();

}

[deshipu]

Olaboga, a cóż to takiego?

Słyszałeś kiedyś może o pętlach?

[Treker (Damian Szymański)]

mateusz_brudnik, witaj na forum! Co to dokładnie za układ i co chciałeś osiągnąć? Taki program można łatwo zwinąć z użyciem kilku pętli. Pytanie tylko, co to ma dokładnie być

[mateusz_brudnik]

mateusz_brudnik, witaj na forum! Co to dokładnie za układ i co chciałeś osiągnąć? Taki program można łatwo zwinąć z użyciem kilku pętli. Pytanie tylko, co to ma dokładnie być

chciałbym mieć dostęp do każdego portu arduino mega z poziomu aplikacji zrobionej w programie visual studio za pomocą portu szeregowego

[Treker (Damian Szymański)]

mateusz_brudnik, rozumiem. Zacznij w takim razie porządkować ten kod np. od tego, że wszystkie wyprowadzenia ustawisz jako wyjścia w jednej pętli for. To na pewno będzie dobry krok w kierunku czytelniejszego programu